Answer - #17
Open
itume wants to merge 9 commits into
Open
Conversation
Owner
|
すでにチェック済みかもしれませんが、こちらの動画でコメントさせてもらいました！ 【前編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube 【後編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube |
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
はじめまして。レビューいただけると嬉しいです。
こだわった点
GateのFARESと役割が被って気持ち悪いですが、Arrayのindexを実装上あてにするのは怖かったので。readmeに書いていただいてますが、Gate::FARESは運賃の話なので、どちらかといえばTicketに動かしたいなと思いました。
作り込んでいくとしたら、区間の判定、区間と運賃の定義は別のClassにしたいなと思いました。
シンプルな課題ながら、結構色んなところで詰まったり、終わった後で他の人の回答を見たりできて、楽しかったです。ありがとうございます。