Answer by sanfrecce-osaka - #12
Open
sanfrecce-osaka wants to merge 5 commits into
Open
Conversation
JunichiIto
reviewed
Aug 24, 2017
| true | ||
| entered_gate = Gate.find(ticket.entered_gate_id) | ||
| section = (self.station_number - entered_gate.station_number).abs | ||
| (section != 0) ? (ticket.fare >= FARES[section - 1]) : false |
Owner
There was a problem hiding this comment.
section > 0 && ticket.fare >= FARES[section - 1]
Owner
|
すでにチェック済みかもしれませんが、こちらの動画でコメントさせてもらいました！ 【前編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube 【後編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanfrecce-osakaです。
レビューよろしくお願いします。
感想
rails力の足りなさを痛感しました。
6時間はかかりすぎ・・・。
すごく勉強になりました。
設問について
Ex.3
同じ駅で降りた場合とそれ以外の場合の判定を三項演算子で一行で簡潔に書けた・・・つもりだったんですが少し読みづらくなってしまったかも・・・。
Ex.4
belongs_toをきちんと理解していなかったせいで一つ余分な処理が入ってしまいました・・・。
Ex.5
保存済みのレコードにexited_gate_idが登録されているかどうかで判定しています。
ただblank?を使うべきだったかも・・・。