[Bug] Wrong behavior for the life extraction#23
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 73.68% 73.91% +0.22%
==========================================
Files 4 4
Lines 114 115 +1
==========================================
+ Hits 84 85 +1
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
so for someone born in 2000, in 2020 at the last column it would go down? |
|
When reaching the last column, go down, but that was already the previous behavior. |
|
Hum... Now tahta i see the codecov report showing that the behavior was not tested before and is still not tested, I really wonder which is the best option of the two. For example, which one produces the more sensible life times for elders ? a life expectency that is not too high ? etc... For the paper, let's make the change to the graphs. For this PR, let's wait until we have proper tests to eventually merge it. Sorry about the noise @rimhajal |
@rimhajal, maybe the graphs you did for the paper could be added to the docs here. But it needs to be fixed because the implemented behavior was in fact wrong. This PR fixes it and your graph shoul dbe fixed accordingly:
So the final trip looks like (d means down and r means right) :
drdrdrdrORrdrdrdrdthenrrrrrrrrrrrif bottom line reached orddddddddif last column reached, then eternity in the last cell.