Skip to content

[Bug] Wrong behavior for the life extraction#23

Open
lrnv wants to merge 2 commits into
mainfrom
lrnv/correct_error_Life
Open

[Bug] Wrong behavior for the life extraction#23
lrnv wants to merge 2 commits into
mainfrom
lrnv/correct_error_Life

Conversation

@lrnv

@lrnv lrnv commented Jul 20, 2024

Copy link
Copy Markdown
Member

@rimhajal, maybe the graphs you did for the paper could be added to the docs here. But it needs to be fixed because the implemented behavior was in fact wrong. This PR fixes it and your graph shoul dbe fixed accordingly:

  • When reaching the last line, we should continue to go right
  • When reaching the last column, we should continue to go down
  • The last cell ONLY is up until infinity, so the red arrow should rather be a red "point" inside the last cell, to indicate the end of the trip here.

So the final trip looks like (d means down and r means right) : drdrdrdr OR rdrdrdrd then rrrrrrrrrrr if bottom line reached or dddddddd if last column reached, then eternity in the last cell.

@lrnv lrnv changed the title [Bug] Wrong behaviro fo the life extraction [Bug] Wrong behavior for the life extraction Jul 20, 2024
@codecov

codecov Bot commented Jul 20, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.91%. Comparing base (84b2edd) to head (e8dbee7).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/Life.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   73.68%   73.91%   +0.22%     
==========================================
  Files           4        4              
  Lines         114      115       +1     
==========================================
+ Hits           84       85       +1     
  Misses         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rimhajal

Copy link
Copy Markdown
Member

so for someone born in 2000, in 2020 at the last column it would go down?

@lrnv

lrnv commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

When reaching the last column, go down, but that was already the previous behavior.
When reaching the last line, go right, which was not the previous behavior

@lrnv

lrnv commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

Hum... Now tahta i see the codecov report showing that the behavior was not tested before and is still not tested, I really wonder which is the best option of the two. For example, which one produces the more sensible life times for elders ? a life expectency that is not too high ? etc...

For the paper, let's make the change to the graphs. For this PR, let's wait until we have proper tests to eventually merge it. Sorry about the noise @rimhajal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants