Stop considering that Geometric has a dispersion parameter#633
Merged
Conversation
This is just incorrect. Fix tests to reflect correct degrees of freedom and therefore AIC, BIC and standard errors. Also avoid defining `dispersion_parameter` fallback for any distribution: it's clearer for users to get a `MethodError` so that they have to define the appropriate method themselves, than silently returning a wrong value. `NegativeBinomial` will be fixed separately as it requires a deeper refactoring of `negbin` (#624).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 8 8
Lines 1213 1213
=======================================
Hits 1176 1176
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreasnoack
approved these changes
Jan 4, 2026
nalimilan
added a commit
that referenced
this pull request
Apr 19, 2026
This is just incorrect. Fix tests to reflect correct degrees of freedom and therefore AIC, BIC and standard errors. Also avoid defining `dispersion_parameter` fallback for any distribution: it's clearer for users to get a `MethodError` so that they have to define the appropriate method themselves, than silently returning a wrong value. `NegativeBinomial` will be fixed separately as it requires a deeper refactoring of `negbin` (#624).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just incorrect. Fix tests to reflect correct degrees of freedom and therefore AIC, BIC and standard errors.
Also avoid defining
dispersion_parameterfallback for any distribution: it's clearer for users to get aMethodErrorso that they have to define the appropriate method themselves, than silently returning a wrong value.NegativeBinomialwill be fixed separately as it requires a deeper refactoring ofnegbin(#624).Fixes #564, and part of #617.