Skip to content

Add satified_skip_solve as a keyword argument for Conda.add#241

Merged
stevengj merged 4 commits into
JuliaPy:masterfrom
mkitti:mkitti/satisfied_skip_solve
Jun 12, 2023
Merged

Add satified_skip_solve as a keyword argument for Conda.add#241
stevengj merged 4 commits into
JuliaPy:masterfrom
mkitti:mkitti/satisfied_skip_solve

Conversation

@mkitti

@mkitti mkitti commented Jun 12, 2023

Copy link
Copy Markdown
Member

Add --satisified-skip-solve as an argument for Conda.add.

This will allow PyCall.jl to ensure that numpy is installed, but not update it if it already in the environment.

@MilesCranmer

MilesCranmer commented Jun 12, 2023

Copy link
Copy Markdown

LGTM

The CI is broken FYI, so just merge

@mkitti

mkitti commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

Yes, but why?

@MilesCranmer

Copy link
Copy Markdown

Broken since November: https://github.com/JuliaPy/Conda.jl/commits/master

@mkitti

mkitti commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

Yes, but why is CI so broken.

@MilesCranmer

Copy link
Copy Markdown

@stevengj any idea?

@mkitti

mkitti commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

What is happening on Windows?

AttributeError: module 'brotli' has no attribute 'error'

@stevengj

Copy link
Copy Markdown
Member

LGTM. The CI problem on Windows is not a regression so it shouldn't be blocking.

@davidanthoff

Copy link
Copy Markdown
Contributor

This seems to breaks CI on x86 ubuntu workflows, see here.

Could this be reverted for now?

Also, the CI here seems unfortunately limited, shouldn't it run on more Julia versions and on things like x86?

@mkitti

mkitti commented Jul 15, 2023

Copy link
Copy Markdown
Member Author

I guess that is because there is no miniforge for x86:
https://github.com/conda-forge/miniforge

@mkitti

mkitti commented Jul 15, 2023

Copy link
Copy Markdown
Member Author

Is there commercial miniconda for x86? https://docs.conda.io/en/latest/miniconda.html

@davidanthoff

Copy link
Copy Markdown
Contributor

There seems to be something, right? It does look like some kind of conda gets installed... There is an info that says that miniconda is being installed.

@mkitti

mkitti commented Jul 16, 2023

Copy link
Copy Markdown
Member Author

My guess is that we are pulling in a very old version of conda when x86 was supported. I will investigate further before trying to sort out the fix.

@mkitti

mkitti commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

@davidanthoff My proposed fix is JuliaPy/PyCall.jl#1045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants