Run FFTW in GC-safe regions#340
Open
JamesWrigley wants to merge 1 commit into
Open
Conversation
Should help prevent GC pressure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 73.45% 73.58% +0.13%
==========================================
Files 5 5
Lines 535 549 +14
==========================================
+ Hits 393 404 +11
- Misses 142 145 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Does this seem to fix the problem in your application? |
Contributor
Author
|
Not sure, I wasn't able to test it yet. Claude did come up with a smaller local reproducer that did seem to be fixed though. In the real application there's lots of threads doing a lot of allocations so memory usage grew quite quickly with multithreaded plans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help prevent GC pressure. In a larger application I observed memory not being reclaimed when doing multithreaded FFTs, which I suspect to be because we were calling FFTW without entering a GC-safe, which blocks the GC when it could be running.
Would it be possible to make a new release with this?