fix: ensure TOML serialization in show() does not break it - #75
Merged
Conversation
pfitzseb
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we happen to get
nothings or other values that TOML.jl can not serialize in the theDataSet's.conf, theshow()method will break printing in the REPL. So let's get rid of all problematic values. We don't care here that it is round-trippable -- this is just for a prettyshowmethod.In addition, there
TOML.print'sto_tomldoes not handle e.g. unsupportedDictkeys. So we also just put a catchall try-catch around it and print something sensible, so that the users wouldn't be presented with a bigshowmethod stacktrace.