fix(ci): green the lean lint job (networkx + pxr/darwin skip-guards) - #17
Conversation
The "Python tests + compliance" lint job (ubuntu-latest, lean deps) went red
after biometric_prior + test_macos merged into master:
- test_phase4_engine_seed → IndexError: harlo.engine's DAG needs networkx (a
light, pure-Python hard dep) which the lean install omitted. Add it.
- test_phase3_persistence → ModuleNotFoundError: pxr (USD-prim tests). Add
pytest.importorskip("pxr") so they skip cleanly when usd-core is absent.
- test_launcher::test_finder_launch_shows_dialog_not_cli → asserts the macOS
Finder/LaunchServices dialog path; running on Linux it takes the prompt path.
Guard with skipif(sys.platform != "darwin").
Consistent with the job's existing ML-extras exclusions: networkx tests now
run; only the genuinely pxr/darwin-specific tests skip on the lean Linux runner.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
Warning Review limit reached
More reviews will be available in 21 minutes and 29 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What
Greens the "Python tests + compliance" lint check, which is currently red on
master(and inherited by #16) afterbiometric_prior+test_macosmerged in. All three failures are environment-fit issues on the leanubuntu-latestrunner, not code defects:test_phase4_engine_seed→IndexErrorharlo.engineDAG needsnetworkx, omitted from the lean installnetworkx(light, pure-Python hard dep)test_phase3_persistence→ModuleNotFoundError: pxrusd-core, intentionally not installedpytest.importorskip("pxr")test_launcher::test_finder_launch_shows_dialog_not_cliskipif(sys.platform != "darwin")Why this shape
The lint job is deliberately the lean, fast Linux subset (it already
--ignores the ML-extra dirs). This keeps that philosophy:networkxis light so its tests now run; only the genuinelypxr/darwin-specific tests skip — no coverage lost on what we actually ship in the lean bundle.Once merged, PR #16 goes green after a
mastersync.🤖 Generated with Claude Code