Skip to content

Move install scripts to helpers - #5

Merged
JoannaaKL merged 1 commit into
mainfrom
simplify
Sep 29, 2025
Merged

Move install scripts to helpers#5
JoannaaKL merged 1 commit into
mainfrom
simplify

Conversation

@JoannaaKL

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings September 29, 2025 13:25
@JoannaaKL
JoannaaKL merged commit 1d92c32 into main Sep 29, 2025
0 of 2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the installation script by moving three install functions (install_neovim, install_git_delta, and install_gh_copilot) from the main install.sh script to the helpers.sh file to improve code organization and modularity.

  • Moved three installation functions from install.sh to helpers.sh
  • Removed the corresponding function calls from the main installation flow
  • Maintained identical function implementations during the move

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
install.sh Removed three install functions and their calls from main()
helpers.sh Added the three moved install functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread install.sh
install_gh_copilot
symlink_dotfiles
install_fonts
install_spaceship

Copilot AI Sep 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions install_neovim, install_git_delta, and install_gh_copilot were moved to helpers.sh but their calls were removed from main() without being replaced. This breaks the installation flow as these tools will no longer be installed. Either add the function calls back or source helpers.sh and call them from there.

Suggested change
install_spaceship
install_spaceship
install_neovim
install_git_delta
install_gh_copilot

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants