Skip to content

test: add TypeScript compiler tests for DashboardLayout component#8105

Open
Robo-Synaptic-Vaish wants to merge 1 commit into
JhaSourav07:mainfrom
Robo-Synaptic-Vaish:test/dashboard-layout-type-compiler
Open

test: add TypeScript compiler tests for DashboardLayout component#8105
Robo-Synaptic-Vaish wants to merge 1 commit into
JhaSourav07:mainfrom
Robo-Synaptic-Vaish:test/dashboard-layout-type-compiler

Conversation

@Robo-Synaptic-Vaish

Copy link
Copy Markdown
Contributor

Description

Fixes #6757

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Summary

  • Added TypeScript compiler validation tests for DashboardLayout.
  • Verified component signature and children prop type stability using expectTypeOf.
  • Added compile-time checks for invalid prop usage using @ts-expect-error.
  • Verified valid ReactNode children rendering and component return type constraints.

Testing

  • npx vitest run "app/(root)/dashboard/layout.type-compiler.test.tsx"
  • npx tsc --noEmit

Visual Preview

N/A (Test-cases only).

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@retenta-bot

retenta-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

This pull request introduces TypeScript compiler validation tests for the DashboardLayout component, which is a great step towards ensuring type safety in our codebase. It follows a similar approach to previous decisions made for the NavLink and AdvancedSettingsPanel components, where compile-time checks were implemented to catch potential issues early. This consistency in testing will help maintain the integrity of our components as they evolve. Thank you for your contribution, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title test: add type compiler tests for DashboardLayout test: add TypeScript compiler tests for DashboardLayout component Jul 16, 2026
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @Robo-Synaptic-Vaish, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Robo-Synaptic-Vaish

Copy link
Copy Markdown
Contributor Author

npm run typecheck is currently failing due to existing type constraint mismatches in:

  • app/generator/components/EditorPanel.type-compiler.test.tsx
  • app/generator/components/PreviewPanel.type-compiler.test.tsx

This PR only introduces:

  • app/(root)/dashboard/layout.type-compiler.test.tsx

The added test passes locally with:

  • npx vitest run "app/(root)/dashboard/layout.type-compiler.test.tsx"
  • npx tsc --noEmit

I verified the PR diff only contains the DashboardLayout type compiler test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(DashboardLayout-type-compiler): verify TypeScript Compiler Validation & Schema Constraints Stability (Variation 10)

1 participant