Name the wordings that appear three times - #190
Merged
Conversation
… repeat Four strings in the settings menu and one on the scene pages each appear three times - at construction, at registration, and in a warning box or a re-chooser. Three copies of the same sentence is three chances for them to drift, so each is now a constant. The other three were in the language dictionaries, where a repeated word is the normal state of affairs: Italian "Velocita" is both video speed and pet speed, Russian "Udalit" is "remove" in several dialogs. Hoisting those into constants would make the tables harder to read and harder to hand to a translator, which is the one thing they exist for, so S1192 is switched off for that directory with the reason written down next to it.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 37 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eight findings left on main after #189, split by whether they were real.
Five were real
Four in
settings_menu.py(Start with the system,Load plugins (advanced),Export settings...,Import settings...) and one inbase_scene_page.py(Not Ready). Each appears three times — at construction, at registration, and again in a warning box or when a file is re-chosen. Three copies of a sentence is three chances for them to drift apart, so each is now a module constant.Three were not
Velocità,СкоростьandУдалитьin the language dictionaries. A translation table is exactly where the same word recurs under different keys: Italian Velocità is both video speed and pet speed; Russian Удалить is "remove" across several dialogs. Hoisting them into constants would make the tables harder to read and harder to hand to a translator — the one thing those files exist for.So S1192 is switched off for
frontengine/utils/multi_language/in a new.sonarcloud.properties, with the reasoning written next to it rather than left as a silent exclusion. Per-issue WONTFIX would need redoing every time a translator repeats a word.Checks
Language switching still verified across all seven languages in both directions: 0 strings left in the previous language, whiteboard still open, page state byte-identical. 858 passed, pyflakes silent.