Fix Whisper model selection caching#425
Open
pumpkinperson996 wants to merge 2 commits into
Open
Conversation
pumpkinperson996
marked this pull request as ready for review
July 20, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoteGeneratorto the transcriber providerWHISPER_MODEL_SIZEstartup defaultRoot cause
NoteGeneratorread the savedwhisper_model_sizesetting but only passed the transcriber type to the provider, so the provider fell back to its default model. The provider also re-readWHISPER_MODEL_SIZEfrom the environment, which allowed Docker's startup default (tiny) to override an explicit frontend selection such aslarge-v3-turbo. Finally, the provider cached one instance per transcriber type, so later model changes could continue reusing the first loaded model.Impact
Explicit model selections from the frontend are now honored by the main Docker service.
WHISPER_MODEL_SIZEremains a fallback when no explicit model is provided, and changing the model selection rebuilds the cached transcriber with the new configuration.Validation
pytest -q tests/test_whisper_config_forwarding.py tests/test_whisper_models.py tests/test_model_download_state.py— 25 passedpython -m py_compile app/services/note.py app/transcriber/transcriber_provider.py tests/test_whisper_config_forwarding.py— passedtest_task_serial_executor.py(the stale test expects serial execution whileConcurrentTaskExecutordefaults to 3 workers)