[SDK-477] 0.82#863
Conversation
|
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
joaodordio
left a comment
joaodordio
left a comment
There was a problem hiding this comment.
PR description is currently empty. Before merging, can we please fill in:
- list of RN 0.82 breaking changes that were considered and how they were handled
- iOS + Android example app build/smoke evidence on both archs
- jest suite green run with the new
@react-native/[email protected] - confirmation that codegen output for
NativeRNIterableAPI.tsstill produces the same bridge surface
| "react": "19.1.4", | ||
| "react-native": "0.81.6", | ||
| "react": "19.1.1", | ||
| "react-native": "0.82.1", |
There was a problem hiding this comment.
React was bumped down from 19.1.4 to 19.1.1 and types/test-renderer match. That's RN 0.82.1's pinned peer, but please call it out in the PR description so consumers know this is a controlled downgrade, not an oversight. Same for the gesture-handler floor bump to ^2.29.1.
| override fun getJSMainModuleName(): String = "index" | ||
|
|
||
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG | ||
|
|
||
| override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED | ||
| override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED |
There was a problem hiding this comment.
The new file is the stock RN 0.82 template, which is fine. One follow-up:
- The example loses the ability to flip Hermes via
IS_HERMES_ENABLEDBuildConfig. If we still want to honor that gradle flag, we need to forward it intogetDefaultReactHostexplicitly. If we don't care anymore, please confirm.
| "hermes-compiler@npm:0.0.0": | ||
| version: 0.0.0 | ||
| resolution: "hermes-compiler@npm:0.0.0" | ||
| checksum: 8b6fc8a64c2fa18c9aa6ddb8831c92253b6a2f10adf7d5d8f361b574f07e91b64f0c44b1370665075c33c17dd71c02fd19422124a3d2aa1717c37006ab12a1f0 | ||
| languageName: node | ||
| linkType: hard | ||
|
|
There was a problem hiding this comment.
Two transitive dep additions worth flagging in the PR description:
[email protected]: RN 0.82's placeholder. Will trip any tool that flags 0.0.0 versions.fb-dotslashvia@react-native/debugger-shell: binary launcher that downloads platform binaries on first use. Confirm it works behind CI proxies (or document the env var to disable the debugger shell).
| resolution: "@react-native/debugger-shell@npm:0.82.1" | ||
| dependencies: | ||
| cross-spawn: ^7.0.6 | ||
| fb-dotslash: 0.5.8 |
There was a problem hiding this comment.
Two transitive dep additions worth flagging in the PR description:
[email protected]: RN 0.82's placeholder. Will trip any tool that flags 0.0.0 versions.fb-dotslashvia@react-native/debugger-shell: binary launcher that downloads platform binaries on first use. Confirm it works behind CI proxies (or document the env var to disable the debugger shell).
2 participants
🔹 JIRA Ticket(s) if any
✏️ Description