fix(cli): select newest blocking PR review (BRIX-1809)#113
fix(cli): select newest blocking PR review (BRIX-1809)#113quay-worker[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Review Findings
Blocking
🔴 [1] Newer stale reviews can still mask actionable current-head feedback
The selector now chooses the newest CHANGES_REQUESTED by submittedAt across all latestReviews rows, then the done-state guard rejects that single pick if its submitted head SHA is not the PR head. That still drops valid feedback when a reviewer submits a newer review against a superseded commit while another unacted CHANGES_REQUESTED review exists on the current head: extractLatestReview returns the stale review at github.ts:1708-1726, and hasActionableReviewFeedback then rejects it at tick.ts:4324-4326 without considering the current-head review. Select the newest blocking review whose commit matches headRefOid when commit metadata is available, only falling back to unconstrained timestamp selection when the head association is unknown. Add a regression with newest stale old-head feedback plus older unacted current-head feedback so this cannot regress.
Review-feedback retrigger logic must select the newest actionable review for the current PR head before applying dedupe, because stale review metadata can otherwise mask valid feedback and strand open PRs.
Non-blocking
None.
9fd167d to
77a6c82
Compare
Summary
Deployment Steps
✅ No manual deployment steps needed, will be fully operational after automated CI deployment.
Test Plan
Pre-merge checklist
Post-deployment verification