Bumped compiler and source to 17, modified compiler plugin execution … - #351
Merged
Merged
Conversation
simonpriadka
force-pushed
the
feature/enable-jdk21
branch
from
June 10, 2026 14:23
69bc2b7 to
df2bad4
Compare
simonpriadka
force-pushed
the
feature/enable-jdk21
branch
8 times, most recently
from
June 12, 2026 09:44
eb9fe41 to
db80c7c
Compare
tommaso-borgato
self-requested a review
June 18, 2026 11:38
…to work with lombok and sundrio and bumped version, created matrix JDK job with maven build speedup and broke down the steps into multiple steps, maven spotless-plugin not depending on style config jar, but referencing the file instead
simonpriadka
force-pushed
the
feature/enable-jdk21
branch
from
June 24, 2026 06:57
db80c7c to
4544256
Compare
| <configuration> | ||
| <java> | ||
| <eclipse> | ||
| <file>${maven.multiModuleProjectDirectory}/style-config/src/main/resources/org/jboss/intersmash/configs/eclipse-formatter.xml</file> |
Member
There was a problem hiding this comment.
not sure about this one...
@simonpriadka I don't recall exactly the context / motivations / etc. about style config changes: can you please summarize them here just for my understanding?
Collaborator
Author
There was a problem hiding this comment.
Motivation was to use the file directly instead of depending on the style-config module to be built prior to running spotless plugin invocations. The change was also reflected into the check style GH action as well, so that it needs just one maven invocation instead of two
Collaborator
Author
There was a problem hiding this comment.
I'll address the removal of the style-config completely when I'll be working on #365
tommaso-borgato
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-T) and BF dependency fetching implementation (-Daether.dependencyCollector.impl=bf) to speed-up repository prepare builds (reduced execution from ~15 minutes to ~6)gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0image on which the Hyperfoil is dependentType of change
test, version modification, documentation, etc.)
Checklist
Issues