-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add support for repo team/collaborator permissions #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this will not be possible as collaborators can be either from inside the organization or external collaborators. the later will not carry the organization suffix. To support both kinds of collaborators you can either require full explicit usernames (ignoring the memberSuffixes completely), i.e.
myusername_mymembersuffixor distinguish between inside and outside collaborators. But I'm not sure whether the GitHub API supports distinguishing collaborators in this way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I am aware, suffixes are only a thing if the Organization belongs to an Enterprise with EMU. Otherwise, all usernames are "global" (without suffix).
Once inside an Enterprise with EMU, you cannot reference "global" accounts, even external collaborators need new accounts to be provisioned via IdP, which will result in those accounts having a suffix.
If my interpretation is right, then, there's no way you can have a mix of collaborators with or without suffix inside the same Organization.