Solving error + Login and Signup Page With Auth. - #464
Closed
Khushii75 wants to merge 4 commits into
Closed
Conversation
👋 Thank you for opening this Pull Request!Your contribution is much appreciated. Our team will review it shortly. 🔎 In the meantime, please:
We look forward to collaborating with you. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Vehigo
Please fill out the following sections to help us review your pull request efficiently.
1. Title
A concise and descriptive title for your pull request. Please follow Conventional Commits guidelines if applicable.
feat: Add signup and login pages with full authentication and theme toggle
2. Description
Provide a detailed description of the changes introduced by this pull request. Explain what was changed and why. Include any relevant context or design decisions.
Provide a detailed description of the changes introduced by this pull request. Explain what was changed and why. Include any relevant context or design decisions.
This pull request introduces fully functional Signup and Login pages for Vehigo, a car rental platform.
1.Key Features Implemented:
-Email/password signup and login using Firebase Authentication.
-Social login integrations: Google, Microsoft, Facebook, and Phone number.
-Light mode (white & blue) and Dark mode (neon dark) toggle with sun/moon icons.
-Sleek modern UI consistent across both pages, optimized for desktop and mobile.
-Footer links connecting Signup ↔ Login pages.
-Fully frontend-based solution — no backend required.
-These changes enhance the user onboarding experience and modernize the authentication interface for Vehigo.
3. Related Issues
Closes: #357
4. Changes Made
List the specific changes implemented in this pull request. Be as specific as possible, referencing file paths or component names where appropriate.
5. Checklist
Before submitting, please ensure you have completed the following:
6. Screenshots/GIFs
Before:
After:
7. Additional Information
Please note that there were multiple conflicts in the previous versions of the signup/login pages. I have carefully resolved all the conflicts and tested the authentication flows to ensure that the pages work as intended.
Earlier, I had to close 3 previous pull requests due to these conflicts, but with this PR, all issues related to design inconsistencies, authentication functionality, and merge conflicts have been addressed to allow a smooth and successful merge.
@Akashshelke07 Check it Out.