Skip to content

Solving error + Login and Signup Page With Auth. - #464

Closed
Khushii75 wants to merge 4 commits into
InnoWebLabs:mainfrom
Khushii75:solving-error-and-login-singup-page
Closed

Solving error + Login and Signup Page With Auth. #464
Khushii75 wants to merge 4 commits into
InnoWebLabs:mainfrom
Khushii75:solving-error-and-login-singup-page

Conversation

@Khushii75

Copy link
Copy Markdown
Contributor

Pull Request Template for Vehigo

Please fill out the following sections to help us review your pull request efficiently.

1. Title

A concise and descriptive title for your pull request. Please follow Conventional Commits guidelines if applicable.

feat: Add signup and login pages with full authentication and theme toggle

2. Description

Provide a detailed description of the changes introduced by this pull request. Explain what was changed and why. Include any relevant context or design decisions.

Provide a detailed description of the changes introduced by this pull request. Explain what was changed and why. Include any relevant context or design decisions.

This pull request introduces fully functional Signup and Login pages for Vehigo, a car rental platform.
1.Key Features Implemented:

-Email/password signup and login using Firebase Authentication.

-Social login integrations: Google, Microsoft, Facebook, and Phone number.

-Light mode (white & blue) and Dark mode (neon dark) toggle with sun/moon icons.

-Sleek modern UI consistent across both pages, optimized for desktop and mobile.

-Footer links connecting Signup ↔ Login pages.

-Fully frontend-based solution — no backend required.

-These changes enhance the user onboarding experience and modernize the authentication interface for Vehigo.

3. Related Issues

Closes: #357

4. Changes Made

List the specific changes implemented in this pull request. Be as specific as possible, referencing file paths or component names where appropriate.

  • Change 1: Created signup1.html with email/password form and social login buttons.
  • Change 2: Created login1.html with matching design and social login.
  • Change 3: Implemented dark/light mode toggle with sun/moon icons.
  • Change 4: Integrated Firebase authentication for email/password and phone login
  • Change 5: Integrated Google Identity Services for Google login.
  • Change 6: Integrated Microsoft Authentication Library (MSAL) for Microsoft login.
  • Change 7: Integrated Facebook SDK for Facebook login.
  • Change 8: Added responsive design and footer links.
  • Change 9: Ensured consistent styling and theme across signup/login pages

5. Checklist

Before submitting, please ensure you have completed the following:

  • I have read the project's contributing guidelines.
  • My code follows the project's coding style and conventions.
  • I have performed a thorough self-review of my own code.
  • I have added comments to my code, especially in complex or non-obvious sections.
  • I have made corresponding updates to the documentation (e.g., README, API docs) if my changes require it.
  • My changes introduce no new warnings or errors during compilation/runtime.
  • I have added new tests or updated existing ones to cover my changes, and they pass locally.
  • Any dependent changes (e.g., API updates, library versions) have been addressed.

6. Screenshots/GIFs

Before:

image image

After:

image image image image image image image

7. Additional Information

Please note that there were multiple conflicts in the previous versions of the signup/login pages. I have carefully resolved all the conflicts and tested the authentication flows to ensure that the pages work as intended.

Earlier, I had to close 3 previous pull requests due to these conflicts, but with this PR, all issues related to design inconsistencies, authentication functionality, and merge conflicts have been addressed to allow a smooth and successful merge.

@Akashshelke07 Check it Out.

@github-actions

Copy link
Copy Markdown

👋 Thank you for opening this Pull Request!

Your contribution is much appreciated. Our team will review it shortly.

🔎 In the meantime, please:

  • Ensure all file changes are correct.
  • Verify that your commits are clean and meaningful.
  • Address any pending review comments if applicable.

We look forward to collaborating with you. 🚀

@Khushii75 Khushii75 closed this Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement of user Experience and UI of Home page, Login Page and sign up page.

1 participant