Restore channel mask after region init on session restore#23
Open
rgracin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Details
The library does save the correct channel mask received from TTN in the
JoinAcceptmessage (cf_list) and attempts to restore it on startup, howeverlorawan_api_set_regionis called afterlorawan_api_join_session_restoreand resets all channel masks back to defaults overwriting the restored configuration.Swapping the call order in
modem_context_init_lightsolorawan_api_join_session_restoreis called afterlorawan_api_set_regionfixes this. It makes sure the stored channel mask is used after reset on first transmission.