#45 - separate out dial_dataclass and dial_service into separate packages#47
Open
Lance-Drane wants to merge 2 commits into
Open
#45 - separate out dial_dataclass and dial_service into separate packages#47Lance-Drane wants to merge 2 commits into
Lance-Drane wants to merge 2 commits into
Conversation
…t_dial_dataclass + dial_service Signed-off-by: Lance-Drane <[email protected]>
Signed-off-by: Lance-Drane <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
This uses UV workspaces to explicitly manage dial_dataclass and dial_service as separate packages (however, both packages share a single lock file for dependencies). This is important because this allows for
dial_dataclassto only have a single dependency (Pydantic) and allows us to publish that package to PyPI.While this MR does not handle this, it may be desirable for
dial_coreto be its own package which depends ondial_dataclass. This could potentially cause issues with #46 thoughBREAKING CHANGES
dial_dataclassimports tointersect_dial_dataclass. (Chosen because I think the PyPI package name should haveintersectin it.)GIT REPO TAGS
The tags are meant to be representative of the
dial_serviceversion, which should always be updated every time we want to publish a new version.dial_dataclassversions get updated tentatively and may "skip" versions, so that its version can stay in sync withdial_service.