Release/1.0.0 rc3#161
Merged
Merged
Conversation
Update publication-request.json to mark this publication as not the initial release by changing "first" from true to false. Reflects that the IKNL PZP Advance Care Planning 1.0.0 release candidate is not the first publication.
Add support for scanning an additional resources directory and creating a shared Bundle for resources not linked to any Patient. Introduce --extra-resources-dir CLI flag (default: input/resources) and update discover_patients_and_resources() and generate_patient_bundles() to accept the extra directory. Collect JSON files from the main resources dir and the extra dir, group instance resources by Patient references found anywhere in each resource, and produce one transaction Bundle per patient. Add create_shared_bundle() to build and write SharedResourcesBundle.json containing ungrouped resources (Practitioner, Organization, etc.) and report resource counts. Minor logging/format tweaks, add Questionnaire to SKIP_RESOURCE_TYPES, and improve printed paths and status messages. Backwards compatible: pass an empty string to disable the extra directory.
Bump FirelyTeam/firely-terminal-pipeline from v0.7.32-alpha2 to v0.8.1 in two workflows (r4_firely_terminal.yaml and r4_firely_terminal_nts.yaml) to pick up the latest pipeline fixes/updates. No other changes to inputs or paths were made.
Add a 'subject' object (patient reference and display) to three QuestionnaireResponse JSON files: HendrikHartman (20201001 and 20221108) and SamiraVanDerSluijs (20251117). Also normalize the author block placement/formatting in the Samira file and ensure the source reference/display remains consistent; minor formatting fixes (whitespace/newline) applied.
Add subject to QuestionnaireResponse resources
Update the StructureDefinition-ACP-ContactPerson intro: replace the prior note that `.relationship:role` is mandatory with documentation of a new slice `.relationship:roleAdditional`. The new slice is bound to ACPContactPersonRoleVS to accommodate ACP dataset role codes not present in the RolCodelijst (for example SNOMED CT code 310141000146103).
Update the ACP ContactPerson StructureDefinition intro to note that the additional slice `.relationship:roleAdditional` includes role codes pre-adopted from the RolCodelijst in zib Contactpersoon v4.1 (2024), adding a reference link. This documents the provenance of codes (e.g. SNOMED CT 310141000146103) and clarifies why the extra slice is present in the profile.
#129 Add roleAdditional slice to ACP ContactPerson intro
Update CapabilityStatement FSH to use type CommunicationRequest (was Communication) for the ACP-InformRelativesRequest profile. Also update the example mermaid sequence diagram to use SNOMED code 223449006 for the CommunicationRequest category, ensuring the diagram and capability statement align with the correct resource type and category code.
#134 Switch to CommunicationRequest; update SNOMED code
Added profile, mapping and two instances. Not double-checked on correctness.
This could be the way to go, but we should consider dedicating a separate query to this piece of information.
… and responses Also changed enableWhen behavior accordingly.
…ncept in responses
Previous approach gave error which could not be fixed (Assignment rules must include at least one space both before and after the '=' sign voor: * compose.include[0].system = "http://fhir.nl/fhir/NamingSystem/uzi-rolcode")
CodeableConcept resulted in 'null!'
Issue #138 Change type choice to boolean for three questionnaire items
Revert "Issue #138 Change type choice to boolean for three questionnaire items"
… and responses Includes fixed enableWhen behaviour
…ecisions regarding medical treatment
Booleans are not allowed to be used with observable entities, therefore we should use a finding code.
Change type choice to boolean for 1406, 984 and 1200 in questionnaire…
ValueSet for Procedure.code is made with snomed, CBV and NZa code. DHD VT code is not included as it is stated that this set should not be used for exchange: "SNOMED CT - SNOMED CT: ^41000147108 | DHD Verrichtingenthesaurus-referentieset (was: DHD Verrichtingenthesaurus - Alle waarden met OID 2.16.840.1.113883.2.4.3.120.5.2. Deze set is echter niet direct bedoeld voor uitwisseling. Zie onder andere [ZIB-1233](https://bits.nictiz.nl/browse/ZIB-1233))" Search query is updated accordingly, and to test new modelling, the examples are changed. This can be undone after review.
Clarify the ACP Legally Capable profile description and adjust element-to-dataset mappings. The profile Description was reworded for clarity. Removed/commented obsolete mapping lines, remapped dataAbsentReason from code 668 to 762, and added note.text -> 763. These changes correct mapping targets and improve the profile documentation.
Questionnaire improvements
Change the 'Geboortedatum patiënt' question (linkId 967) from type "dateTime" to "date" in input/resources/Questionnaire-ACP-zib2020.json so only the date (no time) is recorded for patient birthdates.
Update the ValueSet reference in StructureDefinition-ACP-ContactPerson-intro.md to point to ValueSet-ACP-ContactPersonRoleVS.html (was ValueSet-ACP-ContactPersonRole.html). This is a documentation/link fix only.
Cardinalitiescommunicationrequest
Delete input/fsh/Extension.fsh which defined the ext-Patient.LegallyCapableMedicalTreatmentDecisions FSH extension. The file described a Patient-level extension with two slices: legallyCapable (0..1, boolean) and legallyCapableComment (0..1, string), and referenced the FreedomRestrictingIntervention.LegallyCapable extension as the basis for its purpose.
…R-R4 into Textualimprovements
textual improvements
ArdonToonstra
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.