Questionnaire improvements#155
Merged
Merged
Conversation
…ncept in responses
Previous approach gave error which could not be fixed (Assignment rules must include at least one space both before and after the '=' sign voor: * compose.include[0].system = "http://fhir.nl/fhir/NamingSystem/uzi-rolcode")
CodeableConcept resulted in 'null!'
Remove large inline answerOption arrays from Questionnaire-ACP-zib2020.json and replace them with answerValueSet references to canonical ValueSets. Add util/questionnaire_item_anwserOption_expander.py: a resolver/expander tool that materialises answerValueSet references back into answerOption lists (writes -expanded copies) for tooling (e.g. NLM LHC-Forms) that cannot resolve ValueSet URLs. The script resolves ValueSets from local fsh-generated resources and the FHIR package cache, fills missing displays (preferring nl-NL), supports pre-computed expansions and compose/include logic, and contains a small hardcoded map for unavailable code systems.
…ues to FHIR values
Replace multiple inline answerOption arrays with a single reference to the shared ACP-YesNoUnknown ValueSet (https://api.iknl.nl/docs/pzp/r4/ValueSet/ACP-YesNoUnknownVS) in the Questionnaire resource to centralize the Yes/No/Unknown options. Also normalize several answerCoding.display values from "Ja" to "ja" for consistency. Affects input/resources/Questionnaire-ACP-zib2020.json.
Handle SNOMED semantic tags and prefer parenthesis-free Dutch designations when building display labels. Add SNOMED_SYSTEM constant and a regex-based _clean_display to remove trailing semantic tags (e.g. "ja (kwalificatiewaarde)" -> "ja"). Update _dutch_display to prefer Dutch designations without parenthetical parts and to call _clean_display; propagate an optional system parameter through _dutch_display and _codesystem_display_map and update callers so CodeSystem lookups can apply SNOMED-specific cleaning. This yields cleaner answerOption/display values for SNOMED concepts.
… and responses Includes fixed enableWhen behaviour
Revise input/resources/README.md to reorganize and clarify the questionnaire preparation steps. Replaces the old conditional-expression/FHIRPath instructions with a new Step 4 instructing replacement of answerOption arrays by answerValueSet references; removes the NLM Form Builder fix walkthrough and example JSON. Adds a Step 0 to run util/questionnaire_item_anwserOption_expander.py to expand answer options and a Step 5 to run util/questionnaire_item_prefix_populator.py to populate item prefixes; retains the code-removal script step (renumbered). Updates the export/replace and LHC Forms loading guidance to reference the expanded questionnaire and adjusts step numbering and registration notes for the IG.
MariekeMassa
reviewed
Jun 1, 2026
MariekeMassa
reviewed
Jun 1, 2026
MariekeMassa
reviewed
Jun 1, 2026
| "type": "string", | ||
| "enableWhen": [ | ||
| { | ||
| "question": "1422", |
Collaborator
There was a problem hiding this comment.
Is this enableWhen rule strictly necessary, as 1422 has the code OTH as initial, read-only value?
MariekeMassa
reviewed
Jun 1, 2026
Changed in questionnaire and one QR, still needs to be done for remaining two QRs
The group level was added to the remaining two questionnaire responses for the question 'Gesprek gevoerd in bijzijn van'. Additionally, answer in QR for Samira was changed to SIS.
MariekeMassa
approved these changes
Jun 2, 2026
MariekeMassa
left a comment
MariekeMassa
left a comment
Collaborator
There was a problem hiding this comment.
All changes are discussed and approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126 #131 and #135
Please review carefully. Comments are also in the tickets.
Needs to be done for STU3 as well :(