Fix off-by-one error in vLLM adapter vocab_size calculation#458
Open
dmndxld wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
WhiteboxModelvLLM.post_processing()(src/lm_polygraph/model_adapters/whitebox_model_vllm.py:115), thelog_probmatrix allocation is based on an incorrect
vocab_size:added_tokens_decoder.keys() returns token IDs, not a count. When a model has an added token with ID equal to
vocab_size (e.g., Qwen3 has an added token at ID 151668 while vocab_size is 151668), the matrix is too small. This
causes an IndexError at line 122:
Fix
Convert the max added token ID to a size by adding 1:
Also adds a guard for empty added_tokens_decoder.
Affected models
Any model whose added token IDs >= tokenizer.vocab_size, such as Qwen3.