feat: annotate indel hits with edit type and query position (Indel Positions column)#27
Open
Roman-Young wants to merge 1 commit into
Open
feat: annotate indel hits with edit type and query position (Indel Positions column)#27Roman-Young wants to merge 1 commit into
Roman-Young wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
Indel Positionsoutput column for indel searches, annotating each hit with the edit type, residue, and 1-based query position as we discussed in our meeting.Format
<d/i>: <residue>[<pos or range>]— e.g.d: A[6](deletion ofAat query position 6),i: X[6](insertion ofXbefore query position 6). Exact matches report[].d: A[2,4]. (We chose a range over listing all possible starting positions).Implementation
_to_dataframefrom(query, matched)Indel Positionsin indel mode,Mutated Positionsotherwise, in the same schema slot. Mismatch/exact output is unchanged.Scope
1-indel only (single-residue edits), matching the currently supported
max_indels=1. Will be naturally extended to 2-indels soon.Testing