Skip to content

Add create run logs#68

Merged
satvik007 merged 4 commits into
mainfrom
dev/ram/run_logs
May 29, 2026
Merged

Add create run logs#68
satvik007 merged 4 commits into
mainfrom
dev/ram/run_logs

Conversation

@ramilamparo
Copy link
Copy Markdown
Collaborator

@ramilamparo ramilamparo commented May 19, 2026

@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

Claude finished @ramilamparo's task in 1m 17s —— View job


Review: PR #68 — Add create run logs

  • Gather PR context and diff
  • Launch specialized review subagents
  • Aggregate findings and post review
  • Clean up outdated bot comments

Result: Approved — clean, well-structured addition that follows all established codebase patterns. No security, performance, or code quality issues found. One minor inline suggestion about adding a missing-subcommand-help test entry for the new runs logs intermediate command group.

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@AndrianBdn AndrianBdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to explain what is run log - it is term we coined ourself, there is no alternatives as far as I know. AI system / user could confuse this with something else, so both in SKILL.md / README.md

Clarify what run-level logs are used for in --help, README, and SKILL.md
command tree.
@claude
Copy link
Copy Markdown

claude Bot commented May 26, 2026

Claude finished @ramilamparo's task in 2m 3s —— View job


Review: PR #68 — Add create run logs

  • Gather PR context and diff
  • Launch specialized review subagents
  • Aggregate findings and post review
  • Clean up outdated bot comments

Result: Approved — clean, well-structured addition that follows all established codebase patterns. No security, performance, or code quality issues found. The new commit addresses @AndrianBdn's feedback by adding a clear explanation of what run-level logs are in both README.md and SKILL.md. One minor observation (not blocking) noted in the review about CreateRunLogRequestSchema.comment lacking a .min(1) constraint.

claude[bot]

This comment was marked as outdated.

- Inline runs API methods into the returned object literal and drop unused
  long-form aliases (createRun, listRuns, etc.) to match the pattern used
  by folders/tcases.
- Require non-empty comment in CreateRunLogRequestSchema and add tests
  covering both --comment and --body paths.
@claude
Copy link
Copy Markdown

claude Bot commented May 26, 2026

Claude finished @ramilamparo's task in 5m 3s —— View job


Review: PR #68 — Add create run logs

  • Gather PR context and diff
  • Launch specialized review subagents
  • Aggregate findings and post review
  • Clean up outdated bot comments

Result: Approved — clean, well-structured addition that follows all established codebase patterns. The latest commit addresses prior feedback (.min(1) validation, documentation explaining run-level logs). No security, performance, or blocking code quality issues found. Three minor inline suggestions posted: import type usage, simplifying a test with expectValidationError, and the still-unaddressed missing-subcommand-help entry for runs logs.

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@hi-rai hi-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, apart from few claude comments that I think would be good to address

@claude
Copy link
Copy Markdown

claude Bot commented May 29, 2026

Claude finished @satvik007's task in 5m 11s —— View job


Review: PR #68 — Add create run logs

  • Gather PR context and diff
  • Launch specialized review subagents
  • Aggregate findings and post review
  • Clean up outdated bot comments

Result: Approved — clean, well-structured addition that follows all established codebase patterns. No security, performance, or blocking code quality issues found. Three previously posted inline suggestions remain unaddressed (as noted by @hi-rai): import type for CreateRunLogRequest, use expectValidationError helper in the empty-comment test, and add missing-subcommand-help entry for runs logs.

@satvik007 satvik007 merged commit 0b781b5 into main May 29, 2026
2 checks passed
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-structured addition that follows all established codebase patterns. No security, performance, or blocking code quality issues found.

Three previously posted inline suggestions remain unaddressed (as noted by @hi-rai):

  1. import type for CreateRunLogRequest (src/commands/api/manifests/runs.ts:8) — Used only as a type assertion; should be type CreateRunLogRequest or replaced with Parameters<typeof api.runs.createLog>[2] to match peer endpoints.

  2. Use expectValidationError helper (src/tests/api/runs/logs-create.spec.ts:93-108) — The "rejects empty --comment" test manually reimplements the spy/assert/restore pattern that's already imported and used earlier in the same file.

  3. Add missing-subcommand-help entry (src/tests/missing-subcommand-help.spec.ts) — { args: ['api', 'runs', 'logs'], label: 'api runs logs' } should be added to keep help-text test coverage consistent with other intermediate command groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants