Feat/audit tooling suite#1095
Open
nonso7 wants to merge 4 commits into
Open
Conversation
…SafeD#1032) Introduce a single, shared SEP-41 conformance suite that every token contract must pass, replacing per-contract ad-hoc checks. - sanctifier-test-support: new `sep41_compliance` harness that verifies a contract's source implements all 10 SEP-41 functions with the exact signatures and correct caller authorization (mirrors core's S012 spec, but syn-only so the suite needs no Z3). - new `sep41-compliance` crate runs the suite against 3+ token contracts (my-contract plus reference AMM-LP and deposit-receipt tokens) and asserts that missing functions, wrong signatures, and missing require_auth all fail compliance. - CI: new `cargo test -p sep41-compliance` job in contracts-ci.
Each rule now has a dedicated page with: what it detects, why it matters, a vulnerable and a safe Soroban example, a CVSS v3.1 risk rating, how to fix, and cross-links to related rules. The README rule table now links every S001-S012 code to its page.
Guide for combining Sanctifier's SARIF output with Semgrep, CodeQL, and other SARIF-aware tools: merging multiple SARIF files, GitHub Code Scanning with Sanctifier + CodeQL, a Semgrep + Sanctifier workflow, Slither in a multi-tool pipeline, and exporting findings to Jira/Linear via webhooks. Ships a working Code Scanning workflow plus sample workflows for each integration.
…feD#1035) Add proptest-based fuzzing of the analysis engine: generate random Rust source (structured Soroban contracts, free-form snippets, and arbitrary text) and run every rule, asserting the result is always Ok(findings) or Err(parse_error) and never panics. Runs as a separate CI job with a hard 60-second budget over 10,000 cases. The property test discovered a real crash: deeply nested input overflowed the recursive parser/analyzer stack and aborted the process. Fixed by an EXCESSIVE_NESTING input-validation guard that rejects pathological delimiter nesting before it reaches the recursive passes; the crash input is kept as a regression fixture. Also repairs pre-existing breakage in sanctifier-core that prevented the crate from compiling at all (a brace-spliced analyze_upgrade_patterns / analyze_custom_rules, duplicate SanctifyConfig / scan_events definitions, and an EventIssue field mismatch), without which no core test could run.
|
@nonso7 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nonso7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change, the motivation behind it, and any important implementation details.
Fixes #
Type of change
Testing
List the commands you ran and the scope of validation.
Checklist
mainand merge conflicts are resolved.Closes #1032
Closes #1045
Closes #1042
Closes #1035