feat: JSON data-structure mapping for device presets (#90)#92
feat: JSON data-structure mapping for device presets (#90)#92turfin-logic wants to merge 1 commit into
Conversation
|
Hey @turfin-logic , thanks for changing things some things are really better now. That being said there's still a problem with the order. The RX7700S rule needs to come before the 7040 rule in the list or it quietly picks the wrong setting. There's nothing in the format that tells you this so the next person who adds a Framework model will probably get it wrong... Another thing that changed was moving the Eco, Balance, Performance and Extreme strings into the JSON. I wasn't expecting that. I think it makes things worse. If a key is missing or has a typo the code just passes a string to ryzenadj and nothing happens. No error, no warning, just the wrong behavior. At least when it was, in Python a missing case was obvious... I still think using a match statement with a nested if for the GPU check is a way to do things. Closing this for now. |
As discussed in #90, this PR introduces a JSON-based data-structure mapping framework to decouple hardware variant detection from the core Python scripts.
Changes
This framework allows users to easily add new hardware presets simply by editing a JSON file. Please let me know if any further tweaks are needed!