Skip to content

Migrate post-install inreplace calls (3/15)#294102

Open
MikeMcQuaid wants to merge 3 commits into
mainfrom
install-step-05-inreplace
Open

Migrate post-install inreplace calls (3/15)#294102
MikeMcQuaid wants to merge 3 commits into
mainfrom
install-step-05-inreplace

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Jul 20, 2026

Copy link
Copy Markdown
Member

Three formulae only rewrite guarded configuration values after
installation and do not require arbitrary Ruby.

  • use the shared inreplace spelling and option behaviour
  • serialise literal and regular-expression substitutions
  • preserve missing-file and already-migrated configuration behaviour
  • depend on Homebrew/brew's matching
    Add install step inreplace change

Needs Homebrew/brew#23182

@MikeMcQuaid MikeMcQuaid added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. CI-no-fail-fast-syntax Continue CI tests despite failing GitHub Actions syntax tests. labels Jul 20, 2026
@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 20, 2026
@MikeMcQuaid
MikeMcQuaid changed the base branch from install-step-04-removals to main July 20, 2026 16:46
@MikeMcQuaid MikeMcQuaid added CI-skip-dependents Pass --skip-dependents to brew test-bot. and removed automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast-syntax Continue CI tests despite failing GitHub Actions syntax tests. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jul 20, 2026
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-05-inreplace branch from c453278 to e8d5c59 Compare July 20, 2026 16:48
@MikeMcQuaid
MikeMcQuaid marked this pull request as ready for review July 20, 2026 16:48
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-05-inreplace branch from e8d5c59 to 95a581d Compare July 21, 2026 11:56
@github-actions github-actions Bot added long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jul 21, 2026
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-05-inreplace branch from 95a581d to 2bcfac5 Compare July 21, 2026 12:00
@MikeMcQuaid MikeMcQuaid added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long dependent tests Set a long timeout for dependent testing long build Set a long timeout for formula testing labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MikeMcQuaid