#DEV-2 - Update README.md#3
Open
HolimaX wants to merge 5 commits into
Open
Conversation
This was referenced Oct 8, 2024
**Root cause:** The `package.json` defined `"test": "react-scripts test"` but the project is a pure OpenAPI/Swagger documentation repository with no React source code. There were no dependencies defined in `package.json` at all, so `react-scripts` was never installed and `npm test` would fail with `react-scripts: command not found`. **Fix approach:** Replaced the non-functional `react-scripts test` command with `swagger-cli validate` which is appropriate for an OpenAPI specification project. Added `@apidevtools/swagger-cli` as a dev dependency so that `npm install` correctly installs the validation tool. **Changes made:** - Updated `scripts.test` in `package.json` from `react-scripts test` to `swagger-cli validate postman/schemas/swagger.yaml` - Added `devDependencies` section to `package.json` with `@apidevtools/swagger-cli@^4.0.4` - Verified `npm install` resolves cleanly and `npm test` passes with output `postman/schemas/swagger.yaml is valid`
…6033429 fix: replace react-scripts test with swagger-cli validation
The built-in `checkout` step was using a blobless SSH clone that silently hung in job 26. Replace it with an explicit HTTPS git clone using CIRCLE_PROJECT_USERNAME/REPONAME env vars and a 10m no_output_timeout so failures surface immediately rather than hanging indefinitely.
fix: replace checkout step with explicit HTTPS clone and timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Ecosystem Compatibility set:
Communication channels:
Distribution channels: