Fixed a typo in HPAccount, (initWithAccountType:) switched to NS_ENUM.#4
Open
mertdumenci wants to merge 1 commit into
Open
Fixed a typo in HPAccount, (initWithAccountType:) switched to NS_ENUM.#4mertdumenci wants to merge 1 commit into
mertdumenci wants to merge 1 commit into
Conversation
Member
|
Unless I am mistaken, NS_ENUM was introduced in iOS6. We need to keep iOS5 support on this for now. Can you resubmit with the initWithAccountType fix? It might also be a good idea to modify the TWAPIManager fix to use the good old typedef enum. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initWithaccountType:'ı initWithAccountType yaptım, enumlar NS_ENUMlara geçirildi.