test: match query-auth in client test stubs#6
Open
mokevnin wants to merge 1 commit into
Open
Conversation
Tilda sends publickey/secretkey as query params on every request (auth_query), but the generated client tests stubbed `getprojectslist?publickey,secretkey` — a malformed query that never matches the real `?publickey=...&secretkey=...`, so WebMock blocked the requests (14 failures + 1 error). Stub the actual encoded auth query the client sends. Test-only change. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests went red after the Stainless migration surfaced normal in-repo CI:
client_test.rbhad 14 failures + 1 error, allWebMock::NetConnectNotAllowedError.Root cause: unlike the other SDKs (which authenticate via headers), Tilda sends
publickey/secretkeyas query params on every request (Client#auth_query). The generated tests stubbedhttp://localhost/v1/getprojectslist?publickey,secretkey— a malformed query string that never matches the real request?publickey=My%20Publickey&secretkey=My%20Secretkey, so WebMock rejected every call. These tests could not have passed against this client.Replaced the 15 stub URLs with the actual encoded auth query the client sends. Test-only; no library change.
./scripts/test→ 75 runs, 0 failures, 0 errors;./scripts/lintgreen.🤖 Generated with Claude Code