fix: harden WebSocket auth — dedicated token, header-only, fail closed - #586
Open
MubyLateef wants to merge 1 commit into
Open
fix: harden WebSocket auth — dedicated token, header-only, fail closed#586MubyLateef wants to merge 1 commit into
MubyLateef wants to merge 1 commit into
Conversation
authenticate() in src/lib/websocket.ts fell back to ADMIN_API_KEY when WS_AUTH_TOKEN was unset and accepted the token via a ?token= query parameter (checked before the Authorization header). Query strings leak into access logs, proxy/CDN logs, browser history, and Referer headers, so this exposed the admin REST key over a channel the REST routes deliberately avoid. - Require a dedicated WS_AUTH_TOKEN; no ADMIN_API_KEY fallback. - Accept the token only as `Authorization: Bearer <token>`; drop ?token=. - Fail closed in production when WS_AUTH_TOKEN is unset (dev/test still skip auth for convenience). Timing-safe comparison was already in place. Adds websocket-auth.test.ts and updates .env.example / docs/SETUP.md. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
@MubyLateef Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authenticate() in src/lib/websocket.ts fell back to ADMIN_API_KEY when WS_AUTH_TOKEN was unset and accepted the token via a ?token= query parameter (checked before the Authorization header). Query strings leak into access logs, proxy/CDN logs, browser history, and Referer headers, so this exposed the admin REST key over a channel the REST routes deliberately avoid.
closes #498
Authorization: Bearer <token>; drop ?token=.Timing-safe comparison was already in place. Adds websocket-auth.test.ts and updates .env.example / docs/SETUP.md.
Description
Type of change
Testing checklist
Related issues
Screenshots (if applicable)