fix: make /ready database check reflect real RPC pool health - #585
Open
MubyLateef wants to merge 1 commit into
Open
fix: make /ready database check reflect real RPC pool health#585MubyLateef wants to merge 1 commit into
MubyLateef wants to merge 1 commit into
Conversation
getReadiness() checked `dbMetrics.active >= 0`, which is a non-negative connection count and therefore always true. The database readiness check could never fail, so a broken RPC connection pool alone could never flip GET /ready to not_ready. Add a `healthy` field to PoolMetrics (count of connections that passed their last health check) and use `dbMetrics.healthy > 0` for dbReady. This drops to 0 when the RPC endpoint is unreachable and the periodic health check marks connections bad. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
@MubyLateef Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getReadiness() checked
dbMetrics.active >= 0, which is a non-negative connection count and therefore always true. The database readiness check could never fail, so a broken RPC connection pool alone could never flip GET /ready to not_ready.closes #521
Add a
healthyfield to PoolMetrics (count of connections that passed their last health check) and usedbMetrics.healthy > 0for dbReady. This drops to 0 when the RPC endpoint is unreachable and the periodic health check marks connections bad.Description
Type of change
Testing checklist
Related issues
Screenshots (if applicable)