fix: add configurable request timeout middleware - #579
Open
Promessa1 wants to merge 4 commits into
Open
Conversation
|
@Promessa1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an Express request timeout middleware that applies to all routes, makes the timeout configurable via
REQUEST_TIMEOUT_MS, returns408 Request Timeoutwhen a request exceeds its limit, and enforces a dedicated admin timeout viaADMIN_REQUEST_TIMEOUT_MSso slow clients cannot hold server workers indefinitely.Related Issue
Changes
⏱️ Request Timeout Middleware
[ADD]
src/middleware/requestTimeout.ts408 Request Timeoutwhen the configured duration elapses.[MODIFY]
src/lib/env.tsREQUEST_TIMEOUT_MSwith a default of30000.ADMIN_REQUEST_TIMEOUT_MSwith a default of60000.[MODIFY]
src/index.tsREQUEST_TIMEOUT_MSas the default timeout for the Express app.[MODIFY]
src/routes/admin.tsADMIN_REQUEST_TIMEOUT_MSfor admin endpoints.Verification Results
src/index.tsREQUEST_TIMEOUT_MSenv var (default: 30000)src/lib/env.ts, default 30000requestTimeoutmiddleware sends408 Request TimeoutADMIN_REQUEST_TIMEOUT_MS, default 60000Closes #535