Skip to content

fix: stop fabricating fake EVM transaction hashes in broadcastToChains #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xhaka00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop fabricating fake EVM transaction hashes in broadcastToChains #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/routes/chains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from "../lib/multichain";
import { parseProjectId } from "../middleware/errors";
import { getSolarData, getSatelliteData } from "./iot";
import { computeScores } from "../lib/scoring";
import { computeScores from "../lib/scoring";

const router = Router();

Expand Down Expand Up @@ -38,7 +38,7 @@ router.patch("/:id", (req: Request, res: Response) => {
res.json({ ok: true, chain: getChain(req.params.id as ChainId) });
});

/**
/***
* POST /v1/chains/broadcast/:projectId
* Submit score update to one or more chains.
* Body: { chains?: string[] } — defaults to all enabled chains.
Expand All @@ -48,6 +48,14 @@ router.post("/broadcast/:projectId", async (req: Request, res: Response, next: N
const projectId = parseProjectId(req.params.projectId, "project id");
const { chains } = req.body as { chains?: string[] };

// Only Stellar has a real cross-chain submission implemented.
// EVM chains are not yet supported; return a clear error instead of
// fabricating a fake transaction hash.
const targetChains = (chains ?? getEnabledChains().map((c) => c.id)) as ChainId[];
if (targetChains.some((id) => id !== "stellar")) {
return res.status(501).json({ error: "EVM chain submission not implemented; only Stellar is currently supported." });
}

const solar = getSolarData(projectId);
const satellite = getSatelliteData(projectId);
const scores = computeScores({ solar, satellite });
Expand All @@ -56,7 +64,7 @@ router.post("/broadcast/:projectId", async (req: Request, res: Response, next: N
projectId,
scores.credit_quality,
scores.green_impact,
chains as ChainId[] | undefined,
targetChains.length > 0 ? targetChains : undefined,
);

res.json(result);
Expand Down