Makes the username configurable via settings & small tweaks to method args - #1
Open
Chris-Thornton-Harvard wants to merge 2 commits into
Open
Conversation
… for positional args
|
I ended up re-working the middleware and backend classes to be based on the auth classes from Django 4.2 instead of Django 5.2 and that created a bunch of conflicts with this branch. So - I just manually moved these changes over to the add_authentication_backend branch. |
|
I also added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of args in methods that were expecting 2 positional arguments but were only receiving 1.
Adds support for an optional LTI_TOOL settings object that can have a
use_person_sourcedidboolean.If present and True, use the SIS ID of the user as the username otherwise the users sub value will be used.