RHELMISC 34338: Add client role support (DUT/SUT/Support/Master/Stress)#991
RHELMISC 34338: Add client role support (DUT/SUT/Support/Master/Stress)#991elizashurov wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a structured way to manage client roles in HLK platforms by adding a ClientRole enum and a PlatformClients helper class. It refactors HCKTest and Tests to dynamically resolve primary and auxiliary clients based on these roles, and updates the platform JSON configurations accordingly. The review feedback suggests refining the Sorbet type signature for build_platform_clients to avoid unnecessary nilability, removing an unused index parameter in build_entries, and ensuring consistent boolean return types in download_memory_dumps when no support client is present.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
depends on HCK-CI/rtoolsHCK#81 |
elizashurov
force-pushed
the
RHELMISC-34338
branch
from
98837ce to
bf27a25
Compare
elizashurov
force-pushed
the
RHELMISC-34338
branch
from
bf27a25 to
204c36e
Compare
Add a role field to platform client config. WHQL uses dut/support, SVVP uses sut/master(MC)/stress(SC). Add `ClientRole` and `PlatformClients` to resolve and validate role combinations. Master/stress clients skip driver install and HLK target registration but still join the pool. Signed-off-by: Elizabeth Ashurov <[email protected]>
Add "role": "dut" to c1 and "role": "support" to c2 across all existing platform definitions. Signed-off-by: Elizabeth Ashurov <[email protected]>
Signed-off-by: Elizabeth Ashurov <[email protected]>
elizashurov
force-pushed
the
RHELMISC-34338
branch
from
204c36e to
48eefe2
Compare
3 participants
Add a role field to platform client config.
WHQL uses dut/support,SVVP uses sut/master(MC)/stress(SC).
Add
ClientRoleandPlatformClientsto resolve and validate rolecombinations. Master/stress clients skip driver install and HLK target
registration but still join the pool.