Add link event trigger node.#449
Draft
Hoikas wants to merge 6 commits into
Draft
Conversation
Hoikas
force-pushed
the
link_event_trigger
branch
3 times, most recently
from
0dc2b48 to
c69c4e4
Compare
This is a helper node to abstract away the oddities of dealing with Python File Mods triggering logic. It's hopefully the first of many higher level logic nodes.
Refactor the previous slightly to allow reusing the logic thunk cleverness and add dedicated nodes for changing SDL variables.
This adds two nodes for responding to SDL boolean events. The SDL Bool Trigger node is designed to fire off a Responder when an SDL variable is in the expected boolean state (true or false). Optionally, the Responder can be gated on another SDL variable. The node swaps between xAgeSDLBoolRespond and xAgeSDLBoolAndRespond as needed. As a bonus, the SDL Bool Gate node uses xAgeSDLBoolCondResp to trigger a Responder conditionally based on an activator (eg clickable) and the value of an SDL boolean. This script was added in MOUL but is included in the OfflineKI, so it's a safe bet.
SDL Bool Gate is a better match for things like xAgeSDLBoolAndSet. So, rename this node and move it to the conditions file. I suspect it will not be as useful, so it's ok to yolo it elsewhere.
The "trigger multistage" node was a generic this-player-triggered-it message anyway. We now have some pretty generic SDL setting stuff, and it would be nice to fire those from responders. This is the tool we'll use for that.
This implements a real SDL boolean logic gate node. Some good future work here would be to force a minimum of two input node sockets to be visible at all times.
Hoikas
force-pushed
the
link_event_trigger
branch
from
c69c4e4 to
89d0fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a higher level use case of the xLinkEventTrigger.py file introduced in H-uru/Plasma#1821. RIght now, this is just an example. I still have some iteration to do here, and I would like to add some more high level logic nodes to improve the workflow where Python has to get involved.
Python File nodes are tricky because the attributes are inputs to the script but function logically as outputs. For example, responders appear as an input to a Python file node, but Python file nodes can trigger responders. The inverse is also true. In the case of
xLinkEventTrigger.py, we see the same thing - normally an activator is an input/trigger for a Python file node, but, in this case, the Python script is triggering the activator so that the responder or other things connected under "satisfies" can proceed.