fix: honor configured broker manager credential (#42)#45
Merged
Conversation
…system/manager GridOpticsServer read goss.system.manager and goss.system.manager.password via getProperty() but discarded the results, always connecting to the broker as the hardcoded system/manager. The configured credential is now stored and used at createConnection(). Absent or empty config falls back to system/manager via shared DEFAULT_SYSTEM_MANAGER_USER/PASSWORD constants, so deployments that never set these properties are unchanged. Connect-failure log raised to warn so a bad configured credential is visible without debug logging. Behavior change: a deployment that set these properties (previously ignored) now has them take effect. Tests cover configured-honored, default-when-absent, and default-when-empty.
…to manager) pnnl.goss.core.server.cfg had goss.system.manager.password = managera, which did not match the realm account (system=manager). This was masked while the server hardcoded the credential; once the server honors the configured value, the typo would break broker auth. Verified manager against the realm account in propertyfile.cfg, GossAuthorizingRealm, and SystemBasedRealm.
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The broker system credential was not configurable.
GridOpticsServerreadgoss.system.managerandgoss.system.manager.passwordviagetProperty()but discarded the results, always connecting to the ActiveMQ broker with hardcodedsystem/manager. Any operator who set those properties was silently ignored.Fix
createConnection().system/managervia sharedDEFAULT_SYSTEM_MANAGER_USER/DEFAULT_SYSTEM_MANAGER_PASSWORDconstants, so deployments that never set these properties are unchanged.goss.system.manager.password = manageratomanager, which matches the realm account (system=manager). This was harmless while the credential was hardcoded, but would break broker auth once the config is honored. Verified againstpnnl.goss.core.security.propertyfile.cfg,GossAuthorizingRealm, andSystemBasedRealm.Behavior change
A deployment that set
goss.system.manager[.password](previously ignored) now has those values take effect. Deployments that never set them are unaffected.Testing
GridOpticsServerBrokerCredentialTest: configured-honored, default-when-absent, default-when-empty../gradlew :pnnl.goss.core:buildgreen.Reviews
Reviewed for code quality, security (no credential logging, fails closed, typo re-syncs both sides off one config key), and failure handling.
Related
Closes #42. Tracking #40.