Skip to content

feat(pubsub): Add pubsub_rollback_schema sample#1817

Draft
torreypayne wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
torreypayne:add-pubsub-rollback-schema
Draft

feat(pubsub): Add pubsub_rollback_schema sample#1817
torreypayne wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
torreypayne:add-pubsub-rollback-schema

Conversation

@torreypayne
Copy link
Copy Markdown
Member

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label Bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jun 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for rolling back Google Cloud Pub/Sub schemas to a previous revision, including the rollback implementation, a Gemfile, and integration tests. The review feedback recommends utilizing the client's built-in schema_path helper method instead of manual string interpolation to construct schema resource paths in both the main code and the test file.

Comment thread pubsub/rollback_schema.rb Outdated
Comment thread pubsub/spec/rollback_schema_spec.rb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant