Respect archive_patterns for workflow manager#1655
Conversation
Also add in an archive_pattern for the slurm workflow manager, to capture some useful dot files.
There was a problem hiding this comment.
Code Review
This pull request refactors how archive patterns are collected in the base application class by dynamically iterating over all objects returned by self.objects() and retrieving their archive_patterns attribute. Additionally, it adds an archive pattern for Slurm-specific files (.slurm_*) in the Slurm workflow manager and introduces a new unit test to verify that these files are correctly archived. There are no review comments, and the changes look solid, so I have no additional feedback to provide.
Ramble Performance Test MetricsResults produced with commit: d565508
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1655 +/- ##
========================================
Coverage 93.30% 93.30%
========================================
Files 352 352
Lines 34223 34220 -3
========================================
- Hits 31931 31930 -1
+ Misses 2292 2290 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Also add in an archive_pattern for the slurm workflow manager, to capture some useful dot files.