Skip to content

Respect archive_patterns for workflow manager#1655

Open
linsword13 wants to merge 1 commit into
GoogleCloudPlatform:developfrom
linsword13:wf-archive
Open

Respect archive_patterns for workflow manager#1655
linsword13 wants to merge 1 commit into
GoogleCloudPlatform:developfrom
linsword13:wf-archive

Conversation

@linsword13

Copy link
Copy Markdown
Member

Also add in an archive_pattern for the slurm workflow manager, to capture some useful dot files.

Also add in an archive_pattern for the slurm workflow manager, to capture some useful dot files.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how archive patterns are collected in the base application class by dynamically iterating over all objects returned by self.objects() and retrieving their archive_patterns attribute. Additionally, it adds an archive pattern for Slurm-specific files (.slurm_*) in the Slurm workflow manager and introduces a new unit test to verify that these files are correctly archived. There are no review comments, and the changes look solid, so I have no additional feedback to provide.

@ramble-pr-bot

ramble-pr-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: d565508

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.8872 2.9233 (0cae61a) 2.9249
test_large_template_expansion passed 2.0705 2.1519 (0cae61a) 2.1593
test_many_experiments passed 35.5835 37.2774 (0cae61a) 37.4424
test_many_objects_defaults passed 18.9319 19.9659 (0cae61a) 19.9664
test_matrix_filter_perf passed 1.5095 1.6012 (0cae61a) 1.5951

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (0cae61a) to head (d565508).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1655   +/-   ##
========================================
  Coverage    93.30%   93.30%           
========================================
  Files          352      352           
  Lines        34223    34220    -3     
========================================
- Hits         31931    31930    -1     
+ Misses        2292     2290    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant