Remove Ramble code that supports python2#1649
Open
linsword13 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up Python 2 and Python 3.5 compatibility code, including removing python2 from preferred Python interpreters, dropping __future__ imports, and removing the _PrependFileLoader class. The review feedback suggests updating outdated comments in bin/ramble that still reference Python 2, and removing a redundant self.fullname assignment in RepoLoader.
Ramble Performance Test MetricsResults produced with commit: 34a83df
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1649 +/- ##
===========================================
- Coverage 93.30% 93.29% -0.01%
===========================================
Files 352 352
Lines 34223 34207 -16
===========================================
- Hits 31931 31915 -16
Misses 2292 2292 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Since now Ramble only supports python3.6 and up. * Get rid of mentions of py2 * Remove a couple future imports that were for py2 compatibility. As a result the `_PrependFileLoader` is not needed any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since now Ramble only supports python3.6 and up.
_PrependFileLoaderis not needed any more.