Add (exclude_)where args to workload directive [AI]#1642
Open
douglasjacobsen wants to merge 1 commit into
Open
Add (exclude_)where args to workload directive [AI]#1642douglasjacobsen wants to merge 1 commit into
douglasjacobsen wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces internal filters for workloads using where and exclude_where arguments, allowing experiments to be conditionally dropped during workspace setup. It updates the workload definition, experiment rendering logic, and documentation, and adds corresponding unit and end-to-end tests. A review comment points out an unused capsys fixture in the end-to-end tests that should be removed.
Ramble Performance Test MetricsResults produced with commit: a4a5fe4
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1642 +/- ##
===========================================
+ Coverage 93.29% 93.31% +0.01%
===========================================
Files 352 353 +1
Lines 34181 34251 +70
===========================================
+ Hits 31889 31960 +71
+ Misses 2292 2291 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This commit adds support for filtering experiments at the workload directive level. This can be used to silently reduce the possible experiment definitions, without creating errors. Tests and documentation are added as well.
douglasjacobsen
force-pushed
the
workload-filters
branch
from
e594d56 to
a4a5fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds support for filtering experiments at the workload directive level. This can be used to silently reduce the possible experiment definitions, without creating errors.
Tests and documentation are added as well.