Skip to content

networkservices: add list resources for 10 deferred resources - #18701

Open
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-networkservices-list-resources-followup
Open

networkservices: add list resources for 10 deferred resources#18701
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-networkservices-list-resources-followup

Conversation

@BBBmau

@BBBmau BBBmau commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Adds list-resource generation for 10 networkservices resources that were
scoped out of #18630 (P-17). These do not need #18304 (default_value on
optional location): either base_url hardcodes /locations/global/, or
location is required so the generated test captures it from state.

  • google_network_services_agent_gateway
  • google_network_services_edge_cache_keyset
  • google_network_services_edge_cache_origin
  • google_network_services_edge_cache_service
  • google_network_services_endpoint_policy
  • google_network_services_http_route
  • google_network_services_lb_route_extension
  • google_network_services_lb_traffic_extension
  • google_network_services_service_lb_policies (beta)
  • google_network_services_tcp_route

Still deferred pending #18304 (optional location default global):
Gateway, GrpcRoute, Mesh, TlsRoute.

`google_network_services_agent_gateway`
`google_network_services_edge_cache_keyset`
`google_network_services_edge_cache_origin`
`google_network_services_edge_cache_service`
`google_network_services_endpoint_policy`
`google_network_services_http_route`
`google_network_services_lb_route_extension`
`google_network_services_lb_traffic_extension`
`google_network_services_service_lb_policies`
`google_network_services_tcp_route`

Generate + go build ./google/services/networkservices/ passed.
Acceptance tests not run — GOOGLE_PROJECT / GOOGLE_CREDENTIALS unset.

@BBBmau

BBBmau commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from c2thorn August 19, 2026 00:22
@modular-magician

modular-magician commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c5d1c83:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 28 files changed, 2981 insertions(+)
google-beta provider View Diff 30 files changed, 3264 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
112 100 2 10
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesAgentGatewayListQuery_generated
  • TestAccNetworkServicesEdgeCacheKeysetListQuery_generated
  • TestAccNetworkServicesEdgeCacheOriginListQuery_generated
  • TestAccNetworkServicesEdgeCacheServiceListQuery_generated
  • TestAccNetworkServicesEndpointPolicyListQuery_generated
  • TestAccNetworkServicesHttpRouteListQuery_generated
  • TestAccNetworkServicesLbRouteExtensionListQuery_generated
  • TestAccNetworkServicesLbTrafficExtensionListQuery_generated
  • TestAccNetworkServicesServiceLbPoliciesListQuery_generated
  • TestAccNetworkServicesTcpRouteListQuery_generated

View the replaying VCR build log


Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@BBBmau, @c2thorn VCR tests complete for c5d1c83!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants