Skip to content

test(schema): add discovery cache coverage#2

Open
IFAKA wants to merge 1 commit into
Google-Health-API:mainfrom
IFAKA:test/schema-discovery-cache
Open

test(schema): add discovery cache coverage#2
IFAKA wants to merge 1 commit into
Google-Health-API:mainfrom
IFAKA:test/schema-discovery-cache

Conversation

@IFAKA

@IFAKA IFAKA commented Jul 1, 2026

Copy link
Copy Markdown

Summary

  • Adds focused unit coverage for schema discovery cache reads, writes, and expiry handling.
  • Verifies FetchDiscovery uses a fresh local cache without making a network call.
  • Keeps production behavior unchanged.

Why

pkg/schema previously had no test coverage, while discovery caching is important for avoiding unnecessary discovery document network calls. This is a small, low-risk coverage improvement that does not require Google Health credentials or live API access.

Validation

  • go test ./pkg/schema -v
  • go test ./pkg/schema -cover40.6% coverage
  • go test ./...
  • go vet ./...
  • go build -o ghealth .

@google-cla

google-cla Bot commented Jul 1, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@IFAKA

IFAKA commented Jul 1, 2026

Copy link
Copy Markdown
Author

This is ready for review. I do not have permission to request reviewers directly on this repo, but based on the repo activity @asmitapoddar looks like the right maintainer to route this. Could someone from the project please route/review when available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant