Predicate actions are now actions... ish...#386
Open
giltho wants to merge 4 commits into
Open
Conversation
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only one commit (on top of #385)
This opens the way to actually handling fold/unfold/gunfold/package as memory actions.
At first, I wanted to just remove SLCmds from the syntax entirely, and replace calls to unfold/fold etc with memory actions syntactically in the AST (like I did for predicate calls becoming core predicates). Unfortunately, this was not possible without a massive refactor of lemmas, turning them into procs, and messing with everything @shiva-tk has done for Gillian.
I know that the correct choices wrt to this have been done in the Rocq formalisation, where there are not "lcmds" but only potentially "ghost actions", but changing this in Gillian is too much for now. It will be a valid refactor in the future if you guys want to do this.