Skip to content

WIP handoff (do NOT merge): candidate dial-back fix for scopeless link-local IPv6 — #61 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hartsock wants to merge 1 commit into from
Closed

WIP handoff (do NOT merge): candidate dial-back fix for scopeless link-local IPv6 — #61 #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion agent-mesh-bus/src/bus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,22 @@ async fn dial_reply_peer(
) -> Result<Connection> {
if let Some((pubkey, addr)) = reverse {
if Fingerprint::of_bytes(pubkey.as_bytes()) == peer_fp {
match endpoint.dial(pubkey, [addr]).await {
// CANDIDATE (unverified — see issue #61): augment the dial-back with
// loopback at the source port, mirroring `dial_peer`, so a same-host
// quiet-bind client is reachable when its source is a scopeless
// link-local IPv6. Passed the isolated `quiet_client` test but was
// racy in the full serial suite; the scope_id-preserving fix is
// likely more correct. Left for the transport owner.
let mut dial_addrs = vec![addr];
for lo in [
SocketAddr::new(std::net::Ipv4Addr::LOCALHOST.into(), addr.port()),
SocketAddr::new(std::net::Ipv6Addr::LOCALHOST.into(), addr.port()),
] {
if !dial_addrs.contains(&lo) {
dial_addrs.push(lo);
}
}
match endpoint.dial(pubkey, dial_addrs).await {
Ok(conn) => return Ok(conn),
Err(e) => tracing::debug!(
peer = %peer_fp.short(),
Expand Down
Loading