feat(board): add support for ES3C28P 2.8" display board and fix IDF build environment - #372
Open
TeslaDeathStar wants to merge 3 commits into
Conversation
…nd add new build targets Added hardware support and build target configuration for the ES3C28P 2.8" ESP32-S3 touch display module. Key Changes: - Added `ES3C28P` build target configuration (`configs/sdkconfig.ES3C28P`) along with FT6X36 touch display driver integration. - Included additional target profiles (`Cardputer ADV`, `Marauder V8`, `Marauder Pancake`). - Enhanced build environment setup in `build.py` by prepending standard tool installation paths (`/opt/homebrew/bin`, `/usr/local/bin`, CMake) to `PATH`. - Fixed `esptool` executable resolution and parameter formatting for merging flash binaries across ESP-IDF virtual environments.
✅ Deploy Preview for ghostespdocs canceled.
|
jaylikesbunda
requested changes
Aug 5, 2026
| else if (strcmp(Selected_Option, "Connect to WiFi") == 0) { | ||
| keyboard_view_set_submit_callback(wifi_connect_kb_cb); | ||
| keyboard_view_set_placeholder("WiFi SSID"); | ||
| keyboard_view_set_initial_text(""); |
Member
There was a problem hiding this comment.
this would prevent users from using the correct syntax when entering in credentials
| #endif | ||
| } | ||
|
|
||
| static void sd_card_apply_board_defaults(void) { |
Member
There was a problem hiding this comment.
this should be set in the config not in a new function
| static void sd_card_report_mount_failure(const char *mode, esp_err_t err) { | ||
| char msg[96]; | ||
| if (err == ESP_FAIL) { | ||
| snprintf(msg, sizeof(msg), "SD %s FS fail: use FAT32", mode); |
Member
There was a problem hiding this comment.
we don't know it failed because of wrong partition format this should be removed or changed to a different message
| toast_show("WiFi lost", TOAST_WARN); | ||
| TickType_t now = xTaskGetTickCount(); | ||
| if (wifi_last_lost_toast == 0 || | ||
| now - wifi_last_lost_toast > pdMS_TO_TICKS(30000)) { |
| version: ^1.0.1 | ||
| rules: | ||
| - if: target in ["esp32s3"] | ||
| - if: "target in [esp32s3] && CONFIG_WITH_ETHERNET == True" |
Member
There was a problem hiding this comment.
s3 builds seem to work fine, is this necessary and does it evaluate correctly?
Member
|
if we could keep it to just the new config and only what's necessary for that config and anything else you want to add or change should be moved to another pull request. this looks pretty messy as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hardware support and build target configuration for the ES3C28P 2.8" ESP32-S3 touch display module along with build script environment fixes.
What's new (Author - fill this out)
ES3C28Pbuild target configuration (configs/sdkconfig.ES3C28P) along with FT6X36 touch display driver integration.Cardputer ADV,Marauder V8,Marauder Pancake).Changed
build.pyby prepending standard tool installation paths (/opt/homebrew/bin,/usr/local/bin, CMake) toPATH.esptoolexecutable resolution and parameter formatting for merging flash binaries across ESP-IDF virtual environments.Removed
Verification (Author - fill this out)
#ifdef CONFIG_...or similar: [x] Yes / [ ] N/ALinked Issues
Checklist (Reviewer - don't fill this out)