Skip to content

fix(schedule): preserve scroll position when returning from a session #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GerardPaligot merged 1 commit into from
Jun 11, 2026
Merged

fix(schedule): preserve scroll position when returning from a session #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions features/schedules/schedules-panes/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ kotlin {
implementation(projects.style.speakers)
implementation(projects.style.theme)

implementation(compose.runtimeSaveable)
implementation(compose.components.resources)
}
}
Expand Down
23 changes: 22 additions & 1 deletion ...ules-panes/src/commonMain/kotlin/com/paligot/confily/schedules/panes/ScheduleGridPager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.saveable.listSaver
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import com.paligot.confily.navigation.ActionIds
Expand Down Expand Up @@ -50,7 +52,26 @@ fun ScheduleGridPager(
val snackbarHostState = remember { SnackbarHostState() }
val scope = rememberCoroutineScope()
val notTodayMessage = stringResource(Resource.string.text_now_not_today)
val gridStates = remember(agendas.size) {
// Persist each day's scroll position so it survives the screen leaving
// composition (e.g. navigating to a session detail and back).
val gridStates = rememberSaveable(
agendas.size,
saver = listSaver<List<LazyGridState>, Int>(
save = { states ->
states.flatMap {
listOf(it.firstVisibleItemIndex, it.firstVisibleItemScrollOffset)
}
},
restore = { saved ->
val restored = saved.chunked(2).map { (index, offset) ->
LazyGridState(index, offset)
}
// Always match the current page count so indexing by page is safe,
// even if the number of days changed while away from the screen.
List(agendas.size) { restored.getOrNull(it) ?: LazyGridState() }
}
)
) {
List(agendas.size) { LazyGridState() }
}
LaunchedEffect(key1 = Unit) {
Expand Down
Loading