fix: EM410x load-from-saved-card UID length - #939
Open
bettythegoodboi wants to merge 1 commit into
Open
Conversation
Firmware set_emu_id requires exactly 5 bytes (or 13 for Electra) and only accepts slot types EM410X / EM410X_ELECTRA. Older saves and scan payloads sometimes stored type(u16)+uid, so load-to-slot sent 7 bytes and silently failed (PAR_ERR), while manual 5-byte entry worked. - normalizeEm410xUid strips type prefix / enforces length - map EM410x 16/32/64 to base EM410X for emulation - normalize on save, load, create/edit, Flipper import, T55xx write - surface set_emu_id errors instead of ignoring status - unit tests for legacy and clean UID paths
Owner
|
For reference: How much of this is AI and did you manually test and review the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_emu_idexpects exactly 5 (or 13 Electra) bytestype(u16)+uid(7 bytes), so load failed with PAR_ERR while manual 5-byte entry workedEM410Xfor slot emulation (firmware only emulates base / Electra)Test plan
flutter test test/em410x_uid_test.dart