Skip to content

docs: clarify allocation sidecar payload flow and limitations#314

Merged
Hauke Löffler (hloeffler) merged 9 commits into
mainfrom
docs/clarify-allocation-sidecar-limitations
Jun 26, 2026
Merged

docs: clarify allocation sidecar payload flow and limitations#314
Hauke Löffler (hloeffler) merged 9 commits into
mainfrom
docs/clarify-allocation-sidecar-limitations

Conversation

@hloeffler

Copy link
Copy Markdown
Contributor

Summary

Clarifies the allocation sidecar's payload mechanism and documents a limitation around setting attributes from game server code.

Changes

  • Attributes warning: Added a note that allocation attributes (allocator.nitrado.net/ labels) cannot be set from game server code via the Agones SDK, since the SDK always prefixes with agones.dev/sdk-. Attributes must be configured statically via the GameFabric UI or API.

  • Payload dataflow overview: Added a table and sequence diagram to the "Game server integration" section showing the two data directions (matchmaker → game server, game server → allocator) and which environment variables control each.

  • Callback timing warning: Expanded the existing danger box under "Return a payload to the Allocator" to explain that the sidecar reads callback annotations once at Ready time and caches the result. It does not re-read at allocation time. Also notes that the Agones SDK does not guarantee immediate visibility of SetAnnotation, so annotations should be confirmed before calling Ready().

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the Allocation Sidecar’s allocation payload flow in the Multiplayer Services documentation, including the two payload directions and a limitation around setting allocation attributes at runtime.

Changes:

  • Documented that allocation attributes (allocator.nitrado.net/ labels) cannot be set from game server code via the Agones SDK prefixing behavior.
  • Added a dataflow table and a Mermaid sequence diagram describing matchmaker → game server payload delivery and game server → allocator callback payload return.
  • Expanded the callback payload warning to explain Ready-time caching and the need to ensure annotations are visible before calling Ready().

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot AI review requested due to automatic review settings June 26, 2026 09:29
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings June 26, 2026 09:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot AI review requested due to automatic review settings June 26, 2026 13:27
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings June 26, 2026 13:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot AI review requested due to automatic review settings June 26, 2026 13:35
Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@hloeffler Hauke Löffler (hloeffler) merged commit 34a6685 into main Jun 26, 2026
5 checks passed
@hloeffler Hauke Löffler (hloeffler) deleted the docs/clarify-allocation-sidecar-limitations branch June 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants